[jp] Re: problem in todo.c, proposed fix

Judd Montgomery judd at jpilot.org
Thu Mar 13 17:56:10 EST 2003


Yes, you are in the right place and they are wanted.  To submit a patch 
use the unified diff.  I would have gotten to it quicker.  Thanks for 
the patch though.  Having no patch would have taken a lot longer for me 
to fix.

$ diff -u todo.c todo.c.orig
--- todo.c      Thu Mar 13 17:51:24 2003
+++ todo.c.orig Thu Mar 13 17:50:15 2003
@@ -294,9 +294,7 @@
        br.unique_id = 0;
     }

-   if (unique_id) {
-      *unique_id = br.unique_id;
-   }
+   *unique_id = br.unique_id;
  #ifdef ENABLE_MANANA
     get_pref(PREF_MANANA_MODE, &ivalue, NULL);
     if (ivalue) {


terry at terrytraub.org wrote:
> A deafening silence ensued.  Is this the wrong forum in which to post bug
> fixes?  Are bug fixes even wanted?  Please advise.
> -Terry
> 
> 
> : Hi,
> : I am trying to import a todo file and jpilot 0.99.5 consistently seg faults. Code trace
> : reveals a null pointer assignment in todo.c pc_todo_write().  I hacked the code
> : as below:
> : 
> : 297c297,299
> : <    *unique_id = br.unique_id;
> : ---
> : >    if (unique_id != NULL) {
> : >        *unique_id = br.unique_id;
> : >    }
> : 
> : Sorry, I have no idea how to submit this as a patch, or whether it may have side
> : effects.  Anyway it worked in that I could do my import.  I was restoring files
> : to my Handera after a brief fling with a Sony NZ90.  It's a nice PDA but too
> : much of a brick for my needs.  Maybe an M515?
> _______________________________________________
> jpilot mailing list
> jpilot at jpilot.org
> http://www.jpilot.org/mailman/listinfo/jpilot




More information about the Jpilot mailing list